Repository navigation
fix: Normalize nested multi-context attribute keys - #46
Open
kinyoklion wants to merge 4 commits into
Open
kinyoklion wants to merge 4 commits into
kinyoklion wants to merge 4 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…-multi-context-keys
There was a problem hiding this comment.
Risk: low.
Automated risk review (dry run): Low
This PR would be automatically approved.
Why: Nested multi-context key handling in lib/ldclient-openfeature/impl/context_converter.rb is a small, well-tested SDK bugfix (with matching spec/impl/context_converter_spec.rb coverage) and does not touch infra, auth, CI, or approval-policy files.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
…-multi-context-keys
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Requirements
Related issues
Accepted OFP requirements 2.2–2.4.
Describe the solution you've provided
Normalize nested multi-context attribute names to strings, matching OpenFeature's top-level EvaluationContext. String-keyed nested keys now work, targeting_key takes precedence over key for symbol-keyed hashes too, and reserved attribute validation applies consistently. Keep invalid targeting keys as invalid contexts instead of silently dropping their kind. Frozen input hashes are not mutated. Nested kind attributes are ignored: the top-level attribute name remains the sub-context kind, and kind is not copied into custom attributes.
Describe alternatives you've considered
Reading symbol and string keys independently would still bypass reserved attribute validation for symbol-keyed hashes.
Additional context
The original converter and affected tests were written by Matthew M. Keeler; this fix is by Devin for Ryan. Independent of held lifecycle work in #36/#39. Updated with main a1ce7e1. Six regression cases cover nested kind values user, multi, and a non-string with symbol/string keys; all six fail against main's converter and pass with this fix. Local Ruby 3.4: 87 examples pass; RuboCop clean. CI passes on Linux Ruby 3.4, JRuby 10.0 and Windows Ruby 3.4; Devin Review found no issues.
Implemented in session Audit openfeature-ruby-server provider this week
Review with Devin · Open in Devin Desktop
SDK-3721